Skip to content

Fixed replaced_task_nesting#8500

Merged
Nusnus merged 2 commits intocelery:mainfrom
Katz-Consulting-Group:blm-272
Sep 13, 2023
Merged

Fixed replaced_task_nesting#8500
Nusnus merged 2 commits intocelery:mainfrom
Katz-Consulting-Group:blm-272

Conversation

@Nusnus
Copy link
Member

@Nusnus Nusnus commented Sep 13, 2023 •
edited
Loading

The replaced_task_nesting (docs @ New in version 5.2. ) was missing from the request because it wasn't parsed correctly over the call stack. This made the whole feature invalid as you always lost the replaced_task_nesting value which made it reset to zero.

This PR fixes the handling of replaced_task_nesting and also adds integration tests for the feature that didn't exist before.

@Nusnus Nusnus added this to the 5.3.x milestone Sep 13, 2023
@Nusnus Nusnus requested a review from thedrow September 13, 2023 13:06
@Nusnus Nusnus self-assigned this Sep 13, 2023
@codecov
Copy link

codecov bot commented Sep 13, 2023 •
edited
Loading

Codecov Report

Patch and project coverage have no change.

Comparison is base (133233f) 87.44% compared to head (14f96b1) 87.44%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #8500   +/-   ##
=======================================
  Coverage   87.44%   87.44%           
=======================================
  Files         148      148           
  Lines       18491    18491           
  Branches     3156     3156           
=======================================
  Hits        16169    16169           
  Misses       2033     2033           
  Partials      289      289
Flag Coverage Δ
unittests 87.41% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
celery/app/amqp.py 94.78% <ø> (ø)
celery/app/base.py 96.75% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Nusnus Nusnus marked this pull request as ready for review September 13, 2023 13:50
@Nusnus Nusnus merged commit add91ec into celery:main Sep 13, 2023
@Nusnus Nusnus deleted the blm-272 branch September 13, 2023 14:13
@auvipy
Copy link
Member

auvipy commented Sep 13, 2023

@Nusnus it will be great if you can edit the description section later in the PR to add some detail and context, it would be great for others and people like me O:) It is just a request

@Nusnus
Copy link
Member Author

Nusnus commented Sep 13, 2023

@Nusnus it will be great if you can edit the description section later in the PR to add some detail and context, it would be great for others and people like me O:) It is just a request

I rushed the PR to get to the next one #8501 so I apologize for the lack of context @auvipy - thanks for noticing and sure I'll add it later np !

@Nusnus
Copy link
Member Author

Nusnus commented Sep 16, 2023

@Nusnus it will be great if you can edit the description section later in the PR to add some detail and context, it would be great for others and people like me O:) It is just a request

Done :) @auvipy
See original PR message

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@Nusnus Nusnus

Labels

PR Type: Bugfix

Projects

None yet

Milestone

5.3.x

Development

Successfully merging this pull request may close these issues.

2 participants

@Nusnus @auvipy