Skip to content

Revert "Revert "Add Semgrep to CI""#8478

Merged
Nusnus merged 1 commit intomainfrom
revert-8477-revert-8201-semgrep
Sep 3, 2023
Merged

Revert "Revert "Add Semgrep to CI""#8478
Nusnus merged 1 commit intomainfrom
revert-8477-revert-8201-semgrep

Conversation

@auvipy
Copy link
Copy Markdown
Member

@auvipy auvipy commented Sep 3, 2023

Reverts #8477

@auvipy auvipy requested a review from Nusnus September 3, 2023 06:54
@auvipy
Copy link
Copy Markdown
Member Author

auvipy commented Sep 3, 2023

I'm not sure where it is being used? is it used in your company?

@auvipy
Copy link
Copy Markdown
Member Author

auvipy commented Sep 3, 2023

image
says it needs configuration. if you use it privately I suggest configure it to your company fork, but let me know what we got from this so far from a open source points of view

@Nusnus Nusnus merged commit 6deda86 into main Sep 3, 2023
@Nusnus Nusnus deleted the revert-8477-revert-8201-semgrep branch September 3, 2023 06:56
@Nusnus
Copy link
Copy Markdown
Member

Nusnus commented Sep 3, 2023

We were indeed checking it out via a fork to assess the value it has from an open source point of view as you mentioned, which unfortunately did not come to completion due to the events of the recent months in our team.

My complaint was removing it without discussion. Not that there is no legitimate case for removing it.
You declined their offer but we didn't for the sake of checking if it brings actual value which gave us access to their dashboard which I do watch weekly for High/Critical security findings in Celery and Kombu.

@auvipy

@auvipy
Copy link
Copy Markdown
Member Author

auvipy commented Sep 3, 2023

I see. i thought it was not actually working. care to invite me on the dashboard please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants