Skip to content

Revert "store children with database backend"#8475

Merged
auvipy merged 1 commit intomainfrom
revert-8338-main
Sep 2, 2023
Merged

Revert "store children with database backend"#8475
auvipy merged 1 commit intomainfrom
revert-8338-main

Conversation

@auvipy
Copy link
Copy Markdown
Member

@auvipy auvipy commented Sep 2, 2023

Reverts #8338

@Nusnus we might revert this for now and reintroduce in future with a proper migration support. for migration support I can work

@auvipy auvipy marked this pull request as ready for review September 2, 2023 11:24
@auvipy auvipy added this to the 5.3.x milestone Sep 2, 2023
@auvipy auvipy requested a review from Nusnus September 2, 2023 11:25
@codecov
Copy link
Copy Markdown

codecov bot commented Sep 2, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01% ⚠️

Comparison is base (1aff856) 87.44% compared to head (e5e14ad) 87.43%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8475      +/-   ##
==========================================
- Coverage   87.44%   87.43%   -0.01%     
==========================================
  Files         148      148              
  Lines       18488    18487       -1     
  Branches     3155     3155              
==========================================
- Hits        16166    16165       -1     
  Misses       2033     2033              
  Partials      289      289              
Flag Coverage Δ
unittests 87.40% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
celery/backends/database/models.py 98.27% <ø> (-0.03%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Copy Markdown
Member

@Nusnus Nusnus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. This was a good change but unfortunately not complete. Once we have the remaining changes we can welcome this back.

@auvipy auvipy merged commit 74c8bf7 into main Sep 2, 2023
@Nusnus
Copy link
Copy Markdown
Member

Nusnus commented Sep 2, 2023

@aaronst we're reverting the change in main as we need to release an urgent patch version and we'd be happy to welcome this back once completed.

Ping me if you need any help/review and I'll prioritize it for me due to this situation.

@aaronst
Copy link
Copy Markdown
Contributor

aaronst commented Sep 2, 2023

@Nusnus @auvipy I suggest updating the documentation so that users are aware the database backends are not feature complete. The parent/child relationship between tasks is important and currently broken for any database backend.

@Nusnus Nusnus deleted the revert-8338-main branch September 2, 2023 20:24
@Nusnus
Copy link
Copy Markdown
Member

Nusnus commented Sep 2, 2023

@Nusnus @auvipy I suggest updating the documentation so that users are aware the database backends are not feature complete. The parent/child relationship between tasks is important and currently broken for any database backend.

@aaronst Is it reasonable to ask you please for the remaining changes (the migration) so we can complete it instead of documenting the gap?

@aaronst
Copy link
Copy Markdown
Contributor

aaronst commented Sep 2, 2023

@Nusnus I’m happy to help with the migration, but this bug still needs to be documented if the fix is being reverted.

@auvipy
Copy link
Copy Markdown
Member Author

auvipy commented Jun 12, 2025

I will be happy to accept a

@Nusnus I’m happy to help with the migration, but this bug still needs to be documented if the fix is being reverted.

I'm still open to a doc fix, until the code is fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants