Skip to content

fix os.getcwd() FileNotFoundError#8448

Merged
Nusnus merged 12 commits intocelery:mainfrom
mortimer2015:main
Sep 4, 2023
Merged

fix os.getcwd() FileNotFoundError#8448
Nusnus merged 12 commits intocelery:mainfrom
mortimer2015:main

Conversation

@mortimer2015
Copy link
Contributor

@mortimer2015 mortimer2015 commented Aug 21, 2023

fix os.getcwd() FileNotFoundError

auvipy
auvipy requested changes Aug 21, 2023
View reviewed changes
@codecov
Copy link

codecov bot commented Aug 21, 2023 •
edited
Loading

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (6b3409c) 87.43% compared to head (88d189c) 87.44%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #8448   +/-   ##
=======================================
  Coverage   87.43%   87.44%           
=======================================
  Files         148      148           
  Lines       18486    18491    +5     
  Branches     3155     3156    +1     
=======================================
+ Hits        16164    16169    +5     
  Misses       2033     2033           
  Partials      289      289
Flag Coverage Δ
unittests 87.41% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
celery/utils/imports.py 86.74% <100.00%> (+0.84%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mortimer2015 mortimer2015 requested a review from auvipy August 21, 2023 07:00
@Nusnus
Copy link
Member

Nusnus commented Aug 23, 2023

@mortimer2015 hey - please notice the tests are failing :)

@Nusnus
Copy link
Member

Nusnus commented Aug 24, 2023

It still does unfortunately @mortimer2015
Make sure you're also rebased on the latest main

@Nusnus
Copy link
Member

Nusnus commented Aug 26, 2023

Seems to be partially fixed. Only Windows tests are failing now. @mortimer2015

@auvipy
Copy link
Member

auvipy commented Sep 4, 2023

After checking the pypy failures it seems to be a network issue of github. so I triggered one job to recheck. but could not re run two at once as github do not allow it now

@auvipy auvipy added this to the 5.3.x milestone Sep 4, 2023
@auvipy auvipy requested a review from Nusnus September 4, 2023 08:41
@auvipy
Copy link
Member

auvipy commented Sep 4, 2023

@Nusnus if you have any inputs please share when you have some time.

@Nusnus Nusnus merged commit b6a5bdb into celery:main Sep 4, 2023
@Nusnus
Copy link
Member

Nusnus commented Sep 4, 2023

@Nusnus if you have any inputs please share when you have some time.

I've reviewed the PR again and it looks alright. Nothing else to add :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Nusnus Nusnus Nusnus approved these changes

@auvipy auvipy auvipy approved these changes

Assignees

No one assigned

Labels

PR Type: Bugfix

Projects

None yet

Milestone

5.3.x

Development

Successfully merging this pull request may close these issues.

3 participants

@mortimer2015 @Nusnus @auvipy