Skip to content

Fixed issue: Flags broker_connection_retry_on_startup & broker_connection_retry aren’t reliable #8433#8446

Merged
Nusnus merged 2 commits intocelery:mainfrom
Katz-Consulting-Group:blm-33
Aug 21, 2023
Merged

Fixed issue: Flags broker_connection_retry_on_startup & broker_connection_retry aren’t reliable #8433#8446
Nusnus merged 2 commits intocelery:mainfrom
Katz-Consulting-Group:blm-33

Conversation

@Nusnus
Copy link
Copy Markdown
Member

@Nusnus Nusnus commented Aug 19, 2023

Fixes #8433

This PR has been tested manually so far. Automatic tests will be added later on.

@Nusnus Nusnus added this to the 5.3.x milestone Aug 19, 2023
@Nusnus Nusnus requested a review from thedrow August 19, 2023 15:08
@Nusnus Nusnus self-assigned this Aug 19, 2023
@codecov
Copy link
Copy Markdown

codecov bot commented Aug 21, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (372a7a3) 87.42% compared to head (588aea7) 87.42%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8446   +/-   ##
=======================================
  Coverage   87.42%   87.42%           
=======================================
  Files         148      148           
  Lines       18479    18488    +9     
  Branches     3154     3155    +1     
=======================================
+ Hits        16155    16164    +9     
  Misses       2034     2034           
  Partials      290      290           
Flag Coverage Δ
unittests 87.39% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
celery/worker/consumer/consumer.py 93.65% <100.00%> (+0.15%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Nusnus Nusnus marked this pull request as ready for review August 21, 2023 14:59
@Nusnus Nusnus merged commit dabccf0 into celery:main Aug 21, 2023
@Nusnus Nusnus deleted the blm-33 branch July 23, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Flags broker_connection_retry_on_startup & broker_connection_retry aren’t reliable

1 participant