Skip to content

Support preload options for shell and purge commands #8374

Merged
auvipy merged 7 commits intocelery:mainfrom
dpdoughe:CELERY-8259
Jul 29, 2023
Merged

Support preload options for shell and purge commands #8374
auvipy merged 7 commits intocelery:mainfrom
dpdoughe:CELERY-8259

Conversation

@dpdoughe
Copy link
Copy Markdown
Contributor

Description

Fixes #8259

The pyramid-celery package adds ini and ini-var options to the standard commands. These allow the standard Pyramid ini configuration files to config Celery. With current Celery however, only the worker, beat, and events have been able to be hooked into pyramid-celery's approach. This change supports shell and purge preload options.

@codecov
Copy link
Copy Markdown

codecov bot commented Jul 14, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.17% 🎉

Comparison is base (c4a4dd8) 87.07% compared to head (27ce77b) 87.25%.
Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8374      +/-   ##
==========================================
+ Coverage   87.07%   87.25%   +0.17%     
==========================================
  Files         148      148              
  Lines       18491    18492       +1     
  Branches     3152     3152              
==========================================
+ Hits        16101    16135      +34     
+ Misses       2110     2068      -42     
- Partials      280      289       +9     
Flag Coverage Δ
unittests 87.22% <100.00%> (+0.17%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
celery/bin/purge.py 70.96% <100.00%> (+38.70%) ⬆️
celery/bin/shell.py 61.01% <100.00%> (+27.11%) ⬆️

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

auvipy
auvipy previously approved these changes Jul 26, 2023
Copy link
Copy Markdown
Member

@auvipy auvipy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks good overall

@auvipy
Copy link
Copy Markdown
Member

auvipy commented Jul 26, 2023

@dpdoughe
Copy link
Copy Markdown
Contributor Author

this looks good overall

Thanks. Did you have any thoughts on #8374 (comment) ? I'm not sure where there is some caching or memoization happening that is making the order of the command calls + assertions significant -- although they shouldn't be. Is there something in the Celery testing suite that can be used to guarantee a free command parser so that ini options for example are not recognized after the first preload options call ?

@dpdoughe
Copy link
Copy Markdown
Contributor Author

can you fix the lint errors please https://github.com/celery/celery/actions/runs/5551154931/job/15036678192?pr=8374 ?

Done.

@auvipy auvipy self-requested a review July 28, 2023 04:16
@auvipy auvipy dismissed their stale review July 28, 2023 04:16

changed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Set allow_extra_args to True in context_settings of shell and purge commands

2 participants