Skip to content

integration test: cleanup worker after test case#8361

Merged
auvipy merged 1 commit intocelery:mainfrom
zhu:improve-integration-test
Jul 29, 2023
Merged

integration test: cleanup worker after test case#8361
auvipy merged 1 commit intocelery:mainfrom
zhu:improve-integration-test

Conversation

@zhu
Copy link
Copy Markdown
Contributor

@zhu zhu commented Jul 10, 2023

Note: Before submitting this pull request, please review our contributing
guidelines.

Description

Avoid tests interference from each others.

@codecov
Copy link
Copy Markdown

codecov bot commented Jul 10, 2023 •
edited
Loading

Codecov Report

Patch coverage has no change and project coverage change: -0.10 ⚠️

Comparison is base (c4a4dd8) 87.07% compared to head (0c88bec) 86.98%.

❗ Current head 0c88bec differs from pull request most recent head b2094c6. Consider uploading reports for the commit b2094c6 to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #8361      +/-   ##
==========================================
- Coverage   87.07%   86.98%   -0.10%     
==========================================
  Files         148      148              
  Lines       18491    18511      +20     
  Branches     3152     3155       +3     
==========================================
  Hits        16101    16101              
- Misses       2110     2128      +18     
- Partials      280      282       +2
Flag Coverage Δ
unittests 86.94% <0.00%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
celery/contrib/testing/manager.py 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@zhu zhu changed the title integration test: cleanup worker after test case WIP: integration test: cleanup worker after test case Jul 10, 2023
@zhu zhu marked this pull request as draft July 10, 2023 09:02
@zhu zhu force-pushed the improve-integration-test branch from 0c88bec to b2094c6 Compare July 11, 2023 07:51
@zhu zhu changed the title WIP: integration test: cleanup worker after test case integration test: cleanup worker after test case Jul 11, 2023
@zhu zhu marked this pull request as ready for review July 11, 2023 08:28
@zhu
Copy link
Copy Markdown
Contributor Author

zhu commented Jul 11, 2023

rabbitmq_redis integration test, before:

193 passed, 2 skipped, 10 xfailed, 5 xpassed, 39 warnings, 210 subtests passed, 4 rerun in 1053.75s (0:17:33)

after:

195 passed, 2 skipped, 8 xfailed, 5 xpassed, 39 warnings, 210 subtests passed in 947.91s (0:15:47)

@Nusnus Nusnus self-requested a review July 11, 2023 08:54
@auvipy auvipy self-requested a review July 11, 2023 13:32
auvipy
auvipy reviewed Jul 16, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@auvipy auvipy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

except the more test coverage, or can we ignore that?

Nusnus
Nusnus approved these changes Jul 18, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@Nusnus Nusnus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great PR ! Thank you @zhu
I only wonder if wait_until_idle is the best name - or maybe adding a short doc could do the trick?
Either way, approved by me.

@Nusnus
Copy link
Copy Markdown
Member

Nusnus commented Jul 18, 2023

except the more test coverage, or can we ignore that?

We can ignore the test cov here, yeah

auvipy
auvipy approved these changes Jul 29, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@auvipy auvipy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can improve the naming later i guess

@auvipy auvipy merged commit f3e2e87 into celery:main Jul 29, 2023
@zhu zhu deleted the improve-integration-test branch July 31, 2023 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Nusnus Nusnus Nusnus approved these changes

@auvipy auvipy auvipy approved these changes

Assignees

No one assigned

Labels

Category: Tests CI

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@zhu @Nusnus @auvipy