Stamping bugfix with group/chord header errback linking#8347
Merged
Nusnus merged 9 commits intocelery:mainfrom Jun 28, 2023
Merged
Stamping bugfix with group/chord header errback linking#8347Nusnus merged 9 commits intocelery:mainfrom
Nusnus merged 9 commits intocelery:mainfrom
Conversation
…_cb_on_chord_header is True on the chord header
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #8347 +/- ##
=======================================
Coverage 87.15% 87.15%
=======================================
Files 148 148
Lines 18467 18467
Branches 3148 3148
=======================================
Hits 16095 16095
Misses 2094 2094
Partials 278 278
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When stamping a group that shares a link error, this causes all links to contain the same stamping.
This fix allows each errback to have its own stamps by using
clone()when linking the errback signature.This fix also takes into consideration Chords with the allow_error_cb_on_chord_header flag True.