Skip to content

Update pypy version & CI#8320

Merged
auvipy merged 2 commits intomainfrom
ciup
Jun 17, 2023
Merged

Update pypy version & CI#8320
auvipy merged 2 commits intomainfrom
ciup

Conversation

@auvipy
Copy link
Copy Markdown
Member

@auvipy auvipy commented Jun 17, 2023

No description provided.

@auvipy auvipy added this to the 5.3.x milestone Jun 17, 2023
@codecov
Copy link
Copy Markdown

codecov bot commented Jun 17, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.02 🎉

Comparison is base (e2a02ef) 87.14% compared to head (0b38f42) 87.16%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8320      +/-   ##
==========================================
+ Coverage   87.14%   87.16%   +0.02%     
==========================================
  Files         148      148              
  Lines       18469    18469              
  Branches     3093     3148      +55     
==========================================
+ Hits        16094    16098       +4     
+ Misses       2095     2094       -1     
+ Partials      280      277       -3     
Flag Coverage Δ
unittests 87.12% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@auvipy
Copy link
Copy Markdown
Member Author

auvipy commented Jun 17, 2023

have to wait until the CI is green in for the integration tests

@auvipy
Copy link
Copy Markdown
Member Author

auvipy commented Jun 17, 2023

=================================== FAILURES ===================================
___ test_task_redis_result_backend.test_asyncresult_get_cancels_subscription ___

self = <t.integration.test_tasks.test_task_redis_result_backend object at 0x7f0619facf50>
manager = <celery.contrib.testing.manager.Manager object at 0x7f06180e9990>

  def test_asyncresult_get_cancels_subscription(self, manager):
      channels_before_test = get_active_redis_channels()
  
      result = add.delay(1, 2)
  assert set(get_active_redis_channels()) == {
          f"celery-task-meta-{result.id}".encode(), *channels_before_test
      }

E AssertionError: assert {b'celery-tas...96954d6', ...} == {b'celery-tas...96954d6', ...}
E Extra items in the right set:
E b'celery-task-meta-76bb8a3a-7b5a-4b38-a601-bed49e1f7b21'
E b'celery-task-meta-47561027-6638-4c78-b3fb-2754102aebbe'
E b'celery-task-meta-f5549629-6051-4c8d-8067-5332f7922bb2'
E b'celery-task-meta-282c1327-a718-4127-addd-0dde7e225a04'
E b'celery-task-meta-6b61bb0e-0e36-424c-94a5-b1bfdb65bfbc'
E b'celery-task-meta-e8598954-8f6f-4591-92eb-019dbae7d2a2'...
E
E ...Full output truncated (209 lines hidden), use '-vv' to show

t/integration/test_tasks.py:501: AssertionError
------------------------------ Captured log call -------------------------------
INFO celery.worker.strategy:strategy.py:161 Task t.integration.tasks.add[2b6bbd79-d916-4738-813e-e6b703c908ad] received
=============================== warnings summary ===============================
t/integration/test_canvas.py: 39 warnings
/home/runner/work/celery/celery/celery/canvas.py:2286: CPendingDeprecationWarning: task_allow_error_cb_on_chord_header=False is pending deprecation in a future release of Celery.
Please test the new behavior by setting task_allow_error_cb_on_chord_header to True and report any concerns you might have in our issue tracker before we make a final decision regarding how errbacks should behave when used with chords.
warnings.warn(

-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
=========================== short test summary info ============================
FAILED t/integration/test_tasks.py::test_task_redis_result_backend::test_asyncresult_get_cancels_subscription
!!!!!!!!!!!!!!!!!!!!!!!!!! stopping after 1 failures !!!!!!!!!!!!!!!!!!!!!!!!!!!
= 1 failed, 188 passed, 2 skipped, 11 xfailed, 5 xpassed, 39 warnings, 209 subtests passed, 3 rerun in 737.32s (0:12:17) =

Copy link
Copy Markdown
Member Author

@auvipy auvipy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove pypy 3.10 from integration tests for now

@auvipy auvipy marked this pull request as ready for review June 17, 2023 06:29
@auvipy
Copy link
Copy Markdown
Member Author

auvipy commented Jun 17, 2023

Interestingly the same integration test is not failing after removing pypy3.10 from integration test matrix!

@auvipy auvipy added the CI label Jun 17, 2023
@auvipy auvipy merged commit f17e630 into main Jun 17, 2023
@auvipy auvipy deleted the ciup branch June 17, 2023 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant