Add Google Cloud Storage (GCS) backend #8868
Add Google Cloud Storage (GCS) backend #8868thedrow merged 8 commits intocelery:mainfrom jether-energy:main
Conversation
* Add extra google-cloud-storage requirements * Add gcs backend module * Add gcs backend to userguide configuration * Add gcs to backends in README * Add gcs app Namespace * Add configuration documentation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8868 +/- ##
==========================================
+ Coverage 81.26% 81.30% +0.04%
==========================================
Files 149 150 +1
Lines 18554 18645 +91
Branches 3166 3182 +16
==========================================
+ Hits 15077 15159 +82
- Misses 3191 3196 +5
- Partials 286 290 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| 'azureblockblob': 'celery.backends.azureblockblob:AzureBlockBlobBackend', | ||
| 'arangodb': 'celery.backends.arangodb:ArangoDbBackend', | ||
| 's3': 'celery.backends.s3:S3Backend', | ||
| 'gs': 'celery.backends.gcs:GCSBackend', |
There was a problem hiding this comment.
@haimjether @thedrow something I was wondering about during upgrade-review for celery - is this meant to be registered as gs or is that a typo of gcs?
There was a problem hiding this comment.
@jayaddison , it was meant to be registered as gs , to mimic the blobs path prefix on GCS. E.g
gs://my-bucket/my-folder
The module path is gcs.GCSBackend because Google's commercial product is "GCS" , as opposed to "S3" in AWS
IMHO this is similar to AWS s3 one.
There was a problem hiding this comment.
👍 great, glad to know it's as-intended. Thanks @haimjether!
auvipy
left a comment
There was a problem hiding this comment.
this misses the .. versionadded:: 5.4 annotation
Add extra google-cloud-storage requirements
Add gcs backend module
Add gcs backend to userguide configuration
Add gcs to backends in README
Add gcs app Namespace
Add configuration documentation
Note: Before submitting this pull request, please review our contributing
guidelines.
Description