Merged
Conversation
Nusnus
requested changes
Jan 7, 2024
Member
Nusnus
left a comment
There was a problem hiding this comment.
Very nice addition! Thank you very much!
Please review my comment and tag me for any assistance - it would be an impactful effort improving this aspect of the documentation!
Nusnus
approved these changes
Jan 8, 2024
Member
Nusnus
left a comment
There was a problem hiding this comment.
Adding a link for the good guide for ref, at least in the PR:
https://celery.school/celery-worker-pools
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is a docs page I wish had existed when I started using celery a couple years ago. The current page seems to imply your only two choices are
geventandeventletand that led me down a path of unnecessary operational pain.This page is far from comprehensive, but I don't think it's misleading like the current page is. Also I suspect it's probably a good idea to tell people to stick with prefork unless they have reason not to, especially since other models lack certain features - a fact which AFAICT isn't currently documented at all.