Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (53f3000) 87.45% compared to head (2e818c3) 87.36%.
Report is 81 commits behind head on main.

@@            Coverage Diff             @@
##             main    #8553      +/-   ##
==========================================
- Coverage   87.45%   87.36%   -0.10%     
==========================================
  Files         148      148              
  Lines       18499    18525      +26     
  Branches     3158     3165       +7     
==========================================
+ Hits        16179    16184       +5     
- Misses       2032     2056      +24     
+ Partials      288      285       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

There it is, PR fixed, Ci is all green 👍🏼

What extra benefits the changes will provide?

Today, the only way to provide those values are from cli flag which prevent retrieving those values from any registry (unless you have a way to fetch those values before running those daemons and passing the processed result to the cli, which is not possible in my case).
This change allows to specify those values from settings (like most of the settings you can set on cli), meaning from Python, allowing for dynamic values (which is my use case) and any kind of preprocessing.
This also works for static settings in the case you have a templated celeryconf.py loaded with Celery.config_from_object() (the exact case which is tested in this PR and was not possible without this PR, cf. https://github.com/celery/celery/pull/8553/files#diff-4e22bffa23e4e274ffb04c27895f3bec22ce4c0e41174f5e4dac197c18116a82)

yeah that looks nice. I am in favor of it. Lets us wait for other maintainers to look into it. I would appreciate if in the mean time you could review this PR #8489

In addition, all those new configuration settings should be marked with .. versionadded:: 5.4

@noirbizarre thank you for this PR!
Please add the missing 5.4 doc, and I'll merge it right away.

@noirbizarre the version doc is important for understanding changes on a release and IIRC that's the only gap on this PR.

As we want to improve our communication on releases, I'd appreciate it if you could please close the small gap so we can merge it in, these are nice changes overall and the finishing line is very near! 😉

Hi 👋🏼
Sorry for the lack of response lately (overbooked, holidays, children... life). I'll read the entire thread and update the PR accordingly by the end of week (maybe tonight if the remaining tasks are quick) !

Hi 👋🏼 Sorry for the lack of response lately (overbooked, holidays, children... life). I'll read the entire thread and update the PR accordingly by the end of week (maybe tonight if the remaining tasks are quick) !

Amazing!
Tag me when you’re done and I’ll finish the job on our side.

Thank you!

There it is ! Version added markers for 5.4 added on all settings 👍🏼

Thanks for the review and the merge 🙏🏼

There it is ! Version added markers for 5.4 added on all settings 👍🏼

Thanks for the review and the merge 🙏🏼

Thank you!!
Unfortunately there's one last detail my friend, the version needs to be first under each title and not after the documentation text.

It's important to keep consistency (see other places) so I hope it's not too annoying to ask for this last fix please @noirbizarre 🙏

looks good. just the remaining review issues need to be addressed

Fixed my own comment here: #8802

@noirbizarre all good ❤️

😃

make -C docs changes
open docs/_build/changes/index.html