Skip to content

Lint fixes & pre-commit autoupdate#8414

Merged
Nusnus merged 3 commits intocelery:mainfrom
Katz-Consulting-Group:lint_fixes
Aug 8, 2023
Merged

Lint fixes & pre-commit autoupdate#8414
Nusnus merged 3 commits intocelery:mainfrom
Katz-Consulting-Group:lint_fixes

Conversation

@Nusnus
Copy link
Copy Markdown
Member

@Nusnus Nusnus commented Aug 2, 2023

Replaces #8403 by adding lint fixes based on the upgraded version

@codecov
Copy link
Copy Markdown

codecov bot commented Aug 2, 2023

Codecov Report

Patch coverage: 66.66% and no project coverage change.

Comparison is base (d1273af) 87.42% compared to head (19cd8a2) 87.42%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8414   +/-   ##
=======================================
  Coverage   87.42%   87.42%           
=======================================
  Files         148      148           
  Lines       18479    18479           
  Branches     3154     3154           
=======================================
  Hits        16155    16155           
  Misses       2034     2034           
  Partials      290      290           
Flag Coverage Δ
unittests 87.39% <66.66%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
celery/utils/term.py 96.26% <0.00%> (ø)
celery/app/task.py 94.80% <100.00%> (ø)
celery/backends/cache.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Nusnus Nusnus requested a review from auvipy August 2, 2023 17:21
@Nusnus Nusnus marked this pull request as ready for review August 2, 2023 17:21
Copy link
Copy Markdown
Member

@auvipy auvipy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you please check why the RTD build is failing?

@Nusnus
Copy link
Copy Markdown
Member Author

Nusnus commented Aug 8, 2023

can you please check why the RTD build is failing?

It appears to have been some network hiccup; I rebased on main and now everything works so I'll go ahead and merge :)

@Nusnus Nusnus merged commit 7b4c4c3 into celery:main Aug 8, 2023
@Nusnus Nusnus deleted the lint_fixes branch August 8, 2023 22:18
@auvipy auvipy added this to the 5.3.x milestone Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants