Skip to content

Support sqlalchemy 2.0 in tests#8271

Merged
auvipy merged 2 commits intocelery:mainfrom
danigm:sqlalchemy2
May 30, 2023
Merged

Support sqlalchemy 2.0 in tests#8271
auvipy merged 2 commits intocelery:mainfrom
danigm:sqlalchemy2

Conversation

@danigm
Copy link
Copy Markdown
Contributor

@danigm danigm commented May 29, 2023

Description

This patch updates the call to sqlalchemy.engine.Dialect.dbapi to work with the latest sqlalchemy (2.0). The change is made to be compatible with older version of sqlalchemy so it should work with older versions too.

@auvipy auvipy self-requested a review May 29, 2023 18:16
@auvipy auvipy added this to the 5.3 milestone May 29, 2023
@codecov
Copy link
Copy Markdown

codecov bot commented May 29, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (51d4fc8) 87.16% compared to head (2667309) 87.16%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8271   +/-   ##
=======================================
  Coverage   87.16%   87.16%           
=======================================
  Files         148      148           
  Lines       18469    18469           
  Branches     2524     2524           
=======================================
  Hits        16098    16098           
  Misses       2091     2091           
  Partials      280      280           
Flag Coverage Δ
unittests 87.12% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@auvipy auvipy merged commit 3346868 into celery:main May 30, 2023
bmwiedemann pushed a commit to bmwiedemann/openSUSE that referenced this pull request May 30, 2023
https://build.opensuse.org/request/show/1089865
by user dirkmueller + dimstar_suse
- Add sqlalchemy-2.0.patch to support latest version of sqlalchemy.
  gh#celery/celery#8271
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants