Type annotations for `celery/utils/text.py` by max-muoto · Pull Request #8107 · celery/celery

max-muoto · 2023-03-04T17:56:00Z

Note: Before submitting this pull request, please review our contributing
guidelines.

Description

Type annotations for celery/utils/text.py as a part of #7394.

for more information, see https://pre-commit.ci

max-muoto · 2023-03-04T18:06:48Z

celery/utils/text.py

+           kw: Any) -> str:
    """Format value for printing to console."""
    if isinstance(value, dict):
-        return f'{{{sep} {pformat(value, 4, nl_width)[1:]}'


Syntax error here.

for more information, see https://pre-commit.ci

Nusnus · 2023-03-04T19:16:53Z

There are some issues with the CI so the tests aren't running correctly.
I will handle this soon, FYI

max-muoto · 2023-03-04T19:27:46Z

There are some issues with the CI so the tests aren't running correctly. I will handle this soon, FYI

Sounds good, thanks!

Nusnus · 2023-03-04T20:23:00Z

The failure is real: https://github.com/celery/celery/actions/runs/4332357772/jobs/7565145570#step:8:1002

Nusnus · 2023-03-04T20:24:45Z

      def join(l: list[str], sep: str = '\n') -> str:
  E   TypeError: 'type' object is not subscriptable```

max-muoto · 2023-03-04T20:32:31Z

      def join(l: list[str], sep: str = '\n') -> str:
  E   TypeError: 'type' object is not subscriptable```

My bad there, just fixed!

Nusnus · 2023-03-04T21:33:14Z

ERROR t/unit/bin/test_beat.py - NameError: name 'Match' is not defined
ERROR t/unit/bin/test_worker.py - NameError: name 'Match' is not defined

max-muoto · 2023-03-05T00:51:02Z

ERROR t/unit/bin/test_beat.py - NameError: name 'Match' is not defined
ERROR t/unit/bin/test_worker.py - NameError: name 'Match' is not defined

Ah forgot to quote that, as it should be since it's conditionally imported if type checking is enabled. Fixed.

Having trouble with tox for some reason when trying to test, it just hangs on the pip install steps.

codecov · 2023-03-05T06:08:16Z

Codecov Report

Patch coverage: 96.15% and no project coverage change

Comparison is base (7829247) 87.02% compared to head (8a0739f) 87.02%.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #8107   +/-   ##
=======================================
  Coverage   87.02%   87.02%           
=======================================
  Files         148      148           
  Lines       18444    18445    +1     
  Branches     2515     2515           
=======================================
+ Hits        16050    16051    +1     
  Misses       2116     2116           
  Partials      278      278

Flag	Coverage Δ
unittests	`86.99% <96.15%> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
celery/utils/text.py	`90.90% <96.15%> (+0.10%)`	⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

celery/utils/text.py

for more information, see https://pre-commit.ci

* Annotate text * fix * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix * fix * Add to pyproject * Fix * remove comment * Small fix * remove comment * remoev unused arg * Fix * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix * fix * build fix * type fix * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * pytest==7.2.2 (celery#8106) * Fix * Fix * Type checking fix * Update celery/utils/text.py * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Fix * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Asif Saif Uddin <auvipy@gmail.com>

* Type annotations * small change * unused import * Type annotations for `celery/utils/text.py` (#8107) * Annotate text * fix * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix * fix * Add to pyproject * Fix * remove comment * Small fix * remove comment * remoev unused arg * Fix * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix * fix * build fix * type fix * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * pytest==7.2.2 (#8106) * Fix * Fix * Type checking fix * Update celery/utils/text.py * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Fix * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Asif Saif Uddin <auvipy@gmail.com> * Pre-commit fix * value error change * Fix * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Unit test * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Comment fix * Fix * Future import * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * revert * format fix * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Update celery/apps/beat.py --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Asif Saif Uddin <auvipy@gmail.com>

max-muoto and others added 3 commits March 4, 2023 11:55

Annotate text

8f9c90e

fix

31d271a

[pre-commit.ci] auto fixes from pre-commit.com hooks

f6f0a9e

for more information, see https://pre-commit.ci

max-muoto marked this pull request as ready for review March 4, 2023 17:58

max-muoto added 6 commits March 4, 2023 11:59

fix

67358f8

fix

b277c08

Add to pyproject

06bacac

Fix

ab6771b

remove comment

90fe7bc

Small fix

098afe2

max-muoto commented Mar 4, 2023

View reviewed changes

max-muoto and others added 10 commits March 4, 2023 12:09

remove comment

88c57d5

remoev unused arg

06f4bc6

Fix

7e19e57

[pre-commit.ci] auto fixes from pre-commit.com hooks

6753ea6

for more information, see https://pre-commit.ci

fix

7f15687

fix

324ac08

build fix

a5295e2

type fix

c4691ac

[pre-commit.ci] auto fixes from pre-commit.com hooks

17ccb12

for more information, see https://pre-commit.ci

pytest==7.2.2 (celery#8106)

54add5b

max-muoto added 2 commits March 4, 2023 14:25

Fix

a9357a1

Fix

0f4b5e3

Merge branch 'celery:main' into annotate

bce8766

Type checking fix

8f5f144

auvipy requested changes Mar 5, 2023

View reviewed changes

celery/utils/text.py Show resolved Hide resolved

auvipy and others added 4 commits March 5, 2023 12:09

Update celery/utils/text.py

5885bbf

[pre-commit.ci] auto fixes from pre-commit.com hooks

d37286a

for more information, see https://pre-commit.ci

Fix

2674376

[pre-commit.ci] auto fixes from pre-commit.com hooks

8a0739f

for more information, see https://pre-commit.ci

auvipy added this to the 5.3 milestone Mar 5, 2023

Nusnus self-requested a review March 5, 2023 08:11

auvipy approved these changes Mar 5, 2023

View reviewed changes

auvipy merged commit 32a83e2 into celery:main Mar 5, 2023

max-muoto mentioned this pull request Mar 5, 2023

Plan to annotate Celery #7394

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Type annotations for `celery/utils/text.py`#8107

Type annotations for `celery/utils/text.py`#8107
auvipy merged 27 commits intocelery:mainfrom
max-muoto:annotate

max-muoto commented Mar 4, 2023 •

edited

Loading

Uh oh!

max-muoto Mar 4, 2023

Uh oh!

Nusnus commented Mar 4, 2023

Uh oh!

max-muoto commented Mar 4, 2023

Uh oh!

Nusnus commented Mar 4, 2023

Uh oh!

Nusnus commented Mar 4, 2023

Uh oh!

max-muoto commented Mar 4, 2023

Uh oh!

Nusnus commented Mar 4, 2023 •

edited

Loading

Uh oh!

max-muoto commented Mar 5, 2023 •

edited

Loading

Uh oh!

codecov bot commented Mar 5, 2023 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

max-muoto commented Mar 4, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Uh oh!

max-muoto Mar 4, 2023

Choose a reason for hiding this comment

Uh oh!

Nusnus commented Mar 4, 2023

Uh oh!

max-muoto commented Mar 4, 2023

Uh oh!

Nusnus commented Mar 4, 2023

Uh oh!

Nusnus commented Mar 4, 2023

Uh oh!

max-muoto commented Mar 4, 2023

Uh oh!

Nusnus commented Mar 4, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

max-muoto commented Mar 5, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Mar 5, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

max-muoto commented Mar 4, 2023 •

edited

Loading

Nusnus commented Mar 4, 2023 •

edited

Loading

max-muoto commented Mar 5, 2023 •

edited

Loading

codecov bot commented Mar 5, 2023 •

edited

Loading