Conversation
Codecov ReportBase: 87.00% // Head: 87.00% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #8049 +/- ##
=======================================
Coverage 87.00% 87.00%
=======================================
Files 148 148
Lines 18486 18486
Branches 2520 2520
=======================================
Hits 16083 16083
Misses 2123 2123
Partials 280 280
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
Hey @auvipy , any updates on this PR? |
|
I need manual verification from you or Omer |
Ok so I've been reading a bit about this change, and about the original discussion, and I'm not sure this will fix the issue. The original use-case needs to be tested (manually would be fine too) before we can merge this change, in case I am missing something and the Do you have a way to validate this change indeed fixes the issue? @auvipy |
|
@thedrow Hey can you give it a quick look please? Thanks! |
auvipy
left a comment
There was a problem hiding this comment.
merging as temporary solution and it is used as convention in other parts of CLI
based on comment #7683 (comment)