Skip to content

added missing kwargs arguments in some cli cmd#8049

Merged
auvipy merged 1 commit intomainfrom
shell
Aug 15, 2023
Merged

added missing kwargs arguments in some cli cmd#8049
auvipy merged 1 commit intomainfrom
shell

Conversation

@auvipy
Copy link
Copy Markdown
Member

@auvipy auvipy commented Feb 2, 2023

based on comment #7683 (comment)

@auvipy auvipy requested a review from thedrow February 2, 2023 10:14
@codecov
Copy link
Copy Markdown

codecov bot commented Feb 2, 2023

Codecov Report

Base: 87.00% // Head: 87.00% // No change to project coverage 👍

Coverage data is based on head (77ab8f2) compared to base (cb83eaf).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8049   +/-   ##
=======================================
  Coverage   87.00%   87.00%           
=======================================
  Files         148      148           
  Lines       18486    18486           
  Branches     2520     2520           
=======================================
  Hits        16083    16083           
  Misses       2123     2123           
  Partials      280      280           
Flag Coverage Δ
unittests 86.97% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
celery/bin/shell.py 33.89% <ø> (ø)
celery/bin/celery.py 70.73% <100.00%> (ø)
celery/bin/multi.py 48.38% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@auvipy auvipy marked this pull request as ready for review February 2, 2023 10:26
@Nusnus
Copy link
Copy Markdown
Member

Nusnus commented Feb 19, 2023

Hey @auvipy , any updates on this PR?

@Nusnus Nusnus added this to the 5.3 milestone Feb 19, 2023
@auvipy
Copy link
Copy Markdown
Member Author

auvipy commented Feb 20, 2023

I need manual verification from you or Omer

@Nusnus
Copy link
Copy Markdown
Member

Nusnus commented Feb 23, 2023

I need manual verification from you or Omer

Ok so I've been reading a bit about this change, and about the original discussion, and I'm not sure this will fix the issue.
Adding the **kwargs will only absorb those errors but if the actual kwargs isn't being used as well, then for example where they used --template, it will not be honored as we don't do anything else in this change beside accepting the new arguments.

The original use-case needs to be tested (manually would be fine too) before we can merge this change, in case I am missing something and the kwargs does get used somehow or that everything works if we just "ignore" this exception by absorbing the extra parameters into kwargs.

Do you have a way to validate this change indeed fixes the issue? @auvipy

@Nusnus
Copy link
Copy Markdown
Member

Nusnus commented Mar 2, 2023

@thedrow Hey can you give it a quick look please?
You might be able to judge quickly if we can push/block for testing (as it might not be required).

Thanks!

Copy link
Copy Markdown
Member Author

@auvipy auvipy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merging as temporary solution and it is used as convention in other parts of CLI

@auvipy auvipy modified the milestones: 5.4, 5.3.x Aug 15, 2023
@auvipy auvipy merged commit 7d31b43 into main Aug 15, 2023
@Nusnus Nusnus deleted the shell branch July 23, 2024 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants