Fix duration parsing to support i64 range and add Makefile targets#133
Merged
philhassey merged 3 commits intocedar-policy:mainfrom Mar 4, 2026
Merged
Fix duration parsing to support i64 range and add Makefile targets#133philhassey merged 3 commits intocedar-policy:mainfrom
philhassey merged 3 commits intocedar-policy:mainfrom
Conversation
Contributor
philhassey
commented
Mar 4, 2026
- Fix ParseDuration overflow check from MaxInt32 to proper int64 overflow detection at digit accumulation, unit multiplication, and total accumulation steps.
- Add overflow checking to datetime offset and durationSince eval operations to prevent silent int64 wraparound.
- Add Makefile targets: test, linters, corpus-download, corpus-convert, corpus-update.
- Update DEVELOPMENT.md with make targets, DCO requirements.
- Update corpus GitHub action issue body to reference make targets.
- Suppress false-positive staticcheck warning on json:"-,omitempty" tag.
- Fix ParseDuration overflow check from MaxInt32 to proper int64 overflow detection at digit accumulation, unit multiplication, and total accumulation steps. - Add overflow checking to datetime offset and durationSince eval operations to prevent silent int64 wraparound. - Add Makefile targets: test, linters, corpus-download, corpus-convert, corpus-update. - Update DEVELOPMENT.md with make targets, DCO requirements. - Update corpus GitHub action issue body to reference make targets. - Suppress false-positive staticcheck warning on json:"-,omitempty" tag. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Phil Hassey <phil@strongdm.com>
Signed-off-by: Phil Hassey <phil@strongdm.com> Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
patjakdev
approved these changes
Mar 4, 2026
Signed-off-by: Phil Hassey <phil@strongdm.com> Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.