Error when --image-is-bundle-check flag is set to false while using -b flag #563
Merged
joaopapereira merged 2 commits intocarvel-dev:developfrom Aug 25, 2023
Merged
Error when --image-is-bundle-check flag is set to false while using -b flag #563joaopapereira merged 2 commits intocarvel-dev:developfrom
joaopapereira merged 2 commits intocarvel-dev:developfrom
Conversation
Signed-off-by: ashpect <ashishndiitr@gmail.com>
Member
praveenrewar
left a comment
There was a problem hiding this comment.
Thank you for working on this @ashpect. The change looks good to me. Would you like to add a test for this as well?
Contributor
Author
|
Yes, definitely. |
Contributor
Author
|
Hello @praveenrewar. I added a test for the fix.
|
Signed-off-by: ashpect <ashishndiitr@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This solves #544
Issue
The command
successfully runs and will pull it as an image, which is a bit weird because we are trying to pull a bundle using the bundle flag.
Fix
Now running the command throws this error