Add support for OCI labels on image/bundle push#552
Merged
joaopapereira merged 9 commits intocarvel-dev:developfrom Aug 3, 2023
Merged
Add support for OCI labels on image/bundle push#552joaopapereira merged 9 commits intocarvel-dev:developfrom
joaopapereira merged 9 commits intocarvel-dev:developfrom
Conversation
Signed-off-by: Joe Searcy <joe@twr.io>
Signed-off-by: Joe Searcy <joe@twr.io>
00e3d96 to
63e8348
Compare
Contributor
Author
|
Related to #412 |
Signed-off-by: Joe Searcy <joe@twr.io>
Signed-off-by: Joe Searcy <joe@twr.io>
Signed-off-by: Joe Searcy <joe@twr.io>
joaopapereira
requested changes
Aug 2, 2023
Member
joaopapereira
left a comment
There was a problem hiding this comment.
The change looks good to me. Added some questions and suggestions.
Co-authored-by: João Pereira <joaopapereira@gmail.com> Signed-off-by: Joe Searcy <joe@twr.io>
Signed-off-by: Joe Searcy <joe@twr.io>
Signed-off-by: Joe Searcy <joe@twr.io>
4ff82e7 to
f5d15ff
Compare
Signed-off-by: Joe Searcy <joe@twr.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds the ability for users to specify OCI labels that will be added to the generated OCI artifact (bundle/image) during a
pushoperation.Fixes #153
Example:
The resulting OCI artifact can be inspected as such to show the labels added:
$ regctl image inspect jmsearcy/example-bundle:v1.0.3 { "created": "0001-01-01T00:00:00Z", "architecture": "", "os": "", "config": { "Labels": { "dev.carvel.imgpkg.bundle": "true", "foo.bar": "baz", } }, "rootfs": { "type": "layers", "diff_ids": [ "sha256:f77fc57aa0878a70576e6b45c74ce5a7070219687b92fe073f632d71b7b107f8" ] }, "history": [ { "created": "0001-01-01T00:00:00Z", "created_by": "imgpkg", "author": "imgpkg" } ] }