Issue with bundles multiple repos#508
Merged
joaopapereira merged 8 commits intodevelopfrom Apr 18, 2023
Merged
Conversation
Signed-off-by: Joao Pereira <joaod@vmware.com>
Signed-off-by: Joao Pereira <joaod@vmware.com>
Signed-off-by: Joao Pereira <joaod@vmware.com>
It can read the bundle graph from the registry or from preprocessed images Signed-off-by: Joao Pereira <joaod@vmware.com>
fbc3a44 to
d23bd11
Compare
- Fix race conditions - Refactor some tests Signed-off-by: Joao Pereira <joaod@vmware.com>
3a37268 to
85aa0a7
Compare
cppforlife
reviewed
Apr 11, 2023
Ensure that when fetching a particular bundle there are no 2 concurrent requests for it, while allowing the other requests to continue for different bundles Signed-off-by: Joao Pereira <joaod@vmware.com>
85aa0a7 to
2fcd2ed
Compare
Signed-off-by: Joao Pereira <joaod@vmware.com>
66e61b6 to
1bb4e3a
Compare
Signed-off-by: Joao Pereira <joaod@vmware.com>
cppforlife
approved these changes
Apr 18, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR we now funnel all the requests through the same function that will calculate the Bundle Graph. This required quite some changes but at the same time allowed us to do some improvements in readability of the code
Fixes #499