use queueMicrotask instead of setTimeout in browsers to avoid browser throttling#1761
Merged
aearly merged 1 commit intocaolan:masterfrom Aug 5, 2021
Merged
Conversation
…d browser throttling
|
For reference:
|
sauravazad
approved these changes
Aug 4, 2021
Contributor
Author
|
@sauravazad thanks for the approval. Is there anyone else who needs to approve this? And who has merge/release rights for this? |
Collaborator
|
I'll merge this later today. |
Collaborator
|
Published in v3.2.1 |
Contributor
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since
setTimeoutget throttled by browsers andsetImmediatedoesn't actually exist in any browsers, we should usequeueMicrotaskwhich works very similarly to the intention ofsetImmediate.I have an app that uses stanza.io which relies on async's
priorityQueue. It was found thatpriorityQueueis getting throttled because of its use ofsetTimeout(fn, 0). Most browsers supportqueueMicrotask, but for those who don't, we will fallback.