ci: set proper build tags in golangci and minor cleanup#7183
Merged
mholt merged 6 commits intocaddyserver:masterfrom Aug 21, 2025
Merged
ci: set proper build tags in golangci and minor cleanup#7183mholt merged 6 commits intocaddyserver:masterfrom
mholt merged 6 commits intocaddyserver:masterfrom
Conversation
dunglas
commented
Aug 14, 2025
mholt
reviewed
Aug 14, 2025
Member
mholt
left a comment
There was a problem hiding this comment.
Thanks! I'll also tag @mohammed90 and/or @francislavoie to double-check this if they have a chance.
mohammed90
previously approved these changes
Aug 20, 2025
Member
mohammed90
left a comment
There was a problem hiding this comment.
Looking good! Nothing concerning. Thanks, Kevin!
I missed the removal of GOOS/GOARCH in cross-build CI
1 task
mohammed90
pushed a commit
to cedricziel/caddy
that referenced
this pull request
Aug 29, 2025
…7183) * ci: set proper build tags in golangci and minor cleanup * clean * review --------- Co-authored-by: Matt Holt <mholt@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backported from FrankenPHP. This simplifies the CI a bit and syncs golangci config with the one we use for builds.