Skip to content

refactor: use a more modern writing style to simplify code#7182

Merged
mholt merged 2 commits intocaddyserver:masterfrom
joemicky:master
Aug 20, 2025
Merged

refactor: use a more modern writing style to simplify code#7182
mholt merged 2 commits intocaddyserver:masterfrom
joemicky:master

Conversation

@joemicky
Copy link
Copy Markdown
Contributor

Optimize code using a more modern writing style. Official support from Go, for more details visit https://pkg.go.dev/golang.org/x/tools/gopls/internal/analysis/modernize.

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Aug 14, 2025

CLA assistant check
All committers have signed the CLA.

Comment thread modules/caddyhttp/encode/encode.go Outdated
Comment thread modules/caddyhttp/matchers_test.go Outdated
Comment thread modules/logging/filewriter.go Outdated
Signed-off-by: joemicky <joemickychang@outlook.com>
@joemicky
Copy link
Copy Markdown
Contributor Author

Modified. Please review it again when you have time.

@joemicky
Copy link
Copy Markdown
Contributor Author

Thanks.

Copy link
Copy Markdown
Member

@mholt mholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now too, thank you!

@mholt mholt merged commit 5125fbe into caddyserver:master Aug 20, 2025
23 checks passed
@francislavoie francislavoie added this to the v2.10.1 milestone Aug 22, 2025
mohammed90 pushed a commit to cedricziel/caddy that referenced this pull request Aug 29, 2025
Signed-off-by: joemicky <joemickychang@outlook.com>
Co-authored-by: Matt Holt <mholt@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants