refactor: use slices.Contains to simplify code#7039
Merged
mholt merged 1 commit intocaddyserver:masterfrom May 31, 2025
Merged
Conversation
|
|
mohammed90
requested changes
May 29, 2025
Member
mohammed90
left a comment
There was a problem hiding this comment.
Thank you for the PR! I think they can be simplified further. I've added the suggestion comments. Let me know what you think.
Contributor
Author
|
@mohammed90 Good idea! Thank you for your suggestion; I further simplified the code. Please review it again. |
Signed-off-by: tongjicoder <tongjicoder@icloud.com>
mholt
approved these changes
May 31, 2025
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
1 task
mohammed90
pushed a commit
to cedricziel/caddy
that referenced
this pull request
Aug 29, 2025
Signed-off-by: tongjicoder <tongjicoder@icloud.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a new function added in the go1.21 standard library, which can make the code more concise and easy to read.