fix: Remove nil arg from zapslog.NewHandler call#6984
Merged
mholt merged 1 commit intocaddyserver:masterfrom Apr 28, 2025
Merged
fix: Remove nil arg from zapslog.NewHandler call#6984mholt merged 1 commit intocaddyserver:masterfrom
nil arg from zapslog.NewHandler call#6984mholt merged 1 commit intocaddyserver:masterfrom
Conversation
|
|
nil arg from zapslog.NewHandler callnil arg from zapslog.NewHandler call
126fea7 to
44d8479
Compare
Member
|
Interesting, seems it changed to a variadic parameter in the last year or so. |
dunglas
approved these changes
Apr 28, 2025
1 task
mohammed90
pushed a commit
to cedricziel/caddy
that referenced
this pull request
Aug 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
optsargument in thezapslog.NewHandlerfunction should not be passed asnilhttps://github.com/uber-go/zap/blob/7db06bc9b095571d3dc3d4eebdfbe4dd9bd20405/exp/zapslog/handler.go#L53