Skip to content

caddytls: fix regression in external certificate manager support#7179

Merged
mholt merged 1 commit intocaddyserver:masterfrom
quagsirus:fix-regression
Aug 13, 2025
Merged

caddytls: fix regression in external certificate manager support#7179
mholt merged 1 commit intocaddyserver:masterfrom
quagsirus:fix-regression

Conversation

@quagsirus
Copy link
Copy Markdown
Contributor

@quagsirus quagsirus commented Aug 13, 2025

The fix for #6901 ( e276994 ) appears to have broken support for modules that provide ondemand TLS, such as https://github.com/tailscale/caddy-tailscale

This issue was previously fixed in #6328 but the commit linked above reverts that change. I have tested starting Caddy with the following config after reverting the changes to automation.go, and it appears to still work fine, so I don't think any changes to that file were required to fix #6901

{
	on_demand_tls {
		ask http://localhost:9123/ask
	}
}

https:// {
	tls {
		on_demand
	}
}

Originally posted by @jonaharagon in #6901

in summary - tracking hadExplicitManagers within an AutomationPolicy does not break the config above, and also fixes external certificate provider modules

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Aug 13, 2025

CLA assistant check
All committers have signed the CLA.

Copy link
Copy Markdown
Member

@mholt mholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you -- didn't realize I had conflated a fix when I committed that. Thanks for the patch that strikes the balance and should fix both issues. I am happy to merge this and have people try it out; if there are issues related to this though, can you help with it? Since I'm stretched a bit thin lately.

@quagsirus
Copy link
Copy Markdown
Contributor Author

Yep more than happy to support (as best I can) if stuff goes sideways

@mholt mholt merged commit b898873 into caddyserver:master Aug 13, 2025
23 checks passed
@mholt mholt added the bug 🐞 Something isn't working label Aug 13, 2025
@mholt mholt added this to the v2.10.1 milestone Aug 13, 2025
@quagsirus quagsirus deleted the fix-regression branch August 13, 2025 20:42
mohammed90 pushed a commit to cedricziel/caddy that referenced this pull request Aug 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug 🐞 Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

v2.10.0-beta.2: On-demand TLS cannot be enabled

3 participants