caddytls: fix regression in external certificate manager support#7179
Merged
mholt merged 1 commit intocaddyserver:masterfrom Aug 13, 2025
Merged
caddytls: fix regression in external certificate manager support#7179mholt merged 1 commit intocaddyserver:masterfrom
mholt merged 1 commit intocaddyserver:masterfrom
Conversation
revert changes to automation.go from e276994
mholt
approved these changes
Aug 13, 2025
Member
mholt
left a comment
There was a problem hiding this comment.
Thank you -- didn't realize I had conflated a fix when I committed that. Thanks for the patch that strikes the balance and should fix both issues. I am happy to merge this and have people try it out; if there are issues related to this though, can you help with it? Since I'm stretched a bit thin lately.
Contributor
Author
|
Yep more than happy to support (as best I can) if stuff goes sideways |
1 task
mohammed90
pushed a commit
to cedricziel/caddy
that referenced
this pull request
Aug 29, 2025
…dyserver#7179) revert changes to automation.go from e276994
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fix for #6901 ( e276994 ) appears to have broken support for modules that provide ondemand TLS, such as https://github.com/tailscale/caddy-tailscale
This issue was previously fixed in #6328 but the commit linked above reverts that change. I have tested starting Caddy with the following config after reverting the changes to
automation.go, and it appears to still work fine, so I don't think any changes to that file were required to fix #6901Originally posted by @jonaharagon in #6901
in summary - tracking
hadExplicitManagerswithin anAutomationPolicydoes not break the config above, and also fixes external certificate provider modules