Expand the set of constructors of bindgen!-generated bindings#9177
Merged
alexcrichton merged 2 commits intobytecodealliance:mainfrom Aug 28, 2024
Merged
Expand the set of constructors of bindgen!-generated bindings#9177alexcrichton merged 2 commits intobytecodealliance:mainfrom
bindgen!-generated bindings#9177alexcrichton merged 2 commits intobytecodealliance:mainfrom
Conversation
This commit expands the set of supported constructors for `bindgen!` generated structures with the goal of bringing back `World::new(&mut store, instance)`. This method was removed previously in a refactoring to add `*Pre` structures but refactoring preexisting code to use `*Pre` isn't always easy, so these extra generated bindings provide a smoother migration path for code from before.
pchickey
approved these changes
Aug 28, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit expands the set of supported constructors for
bindgen!generated structures with the goal of bringing backWorld::new(&mut store, instance). This method was removed previously in a refactoring to add*Prestructures but refactoring preexisting code to use*Preisn't always easy, so these extra generated bindings provide a smoother migration path for code from before.