winch: Improve result handling for Aarch64#9171
Merged
fitzgen merged 2 commits intobytecodealliance:mainfrom Aug 27, 2024
Merged
winch: Improve result handling for Aarch64#9171fitzgen merged 2 commits intobytecodealliance:mainfrom
fitzgen merged 2 commits intobytecodealliance:mainfrom
Conversation
This commit introduces missing tests for Aarch64's ABI implementation. Compared to the x64 counterpart, the aarch64 implementation was missing tests for multi-value. Additionally, this commit fixes an issue with how multi-value returns are handlded in Winch's default calling convention, which only allows 1 register result, independent of the register class. This commit also refactors the register indexing environment so that it can be easily shared across the existing backends.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit introduces missing tests for Aarch64's ABI implementation. Compared to the x64 counterpart, the aarch64 implementation was missing tests for multi-value.
Additionally, this commit fixes an issue with how multi-value returns are handlded in Winch's default calling convention, which only allows 1 register result, independent of the register class.
This commit also refactors the register indexing environment so that it can be easily shared across the existing backends.