Winch aarch64 memory load & store#9092
Merged
saulecabrera merged 6 commits intobytecodealliance:mainfrom Aug 13, 2024
Merged
Conversation
Member
|
Redirecting review to @saulecabrera |
Member
saulecabrera
left a comment
There was a problem hiding this comment.
Looking good. Left one minor comment before landing this one.
| src, | ||
| dst, | ||
| size, | ||
| kind.is_some(), // kind is some if the value is signed |
Member
There was a problem hiding this comment.
Could ldr instead of accepting a boolean accept Option<ExtKind>? Or instead -- and maybe this is what I'd prefer -- we could introduce two methods at the assembler level:
sloaduload
And we could dispatch from wasm_load to the corresponding method depending on the value of kind, this would make more explicit depending on the extension kind. Additionally this would make it less error prone than passing a boolean.
saulecabrera
approved these changes
Aug 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey 👋
This PR implements
wasm_load,wasm_storeandload_ptrinstructions for winch targeting aarch64.#8321