Skip to content

Add initial f16 and f128 support to the x64 backend#9045

Merged
fitzgen merged 1 commit intobytecodealliance:mainfrom
beetrees:f16-f128-x64-mvp
Jul 30, 2024
Merged

Add initial f16 and f128 support to the x64 backend#9045
fitzgen merged 1 commit intobytecodealliance:mainfrom
beetrees:f16-f128-x64-mvp

Conversation

@beetrees
Copy link
Copy Markdown
Contributor

This PR adds initial support for passing f16 and f128 values around to the x64 backend. Support is added for the load, store, bitcast, f16const and f128const CLIF instructions.

As a side effect of this PR generalising x64 bitcast support, this PR fixes (for x64) #6104.

f16/f128 issue: #8312

@beetrees beetrees requested a review from a team as a code owner July 30, 2024 18:17
@beetrees beetrees requested review from fitzgen and removed request for a team July 30, 2024 18:17
Copy link
Copy Markdown
Member

@fitzgen fitzgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@fitzgen fitzgen added this pull request to the merge queue Jul 30, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 30, 2024
@beetrees
Copy link
Copy Markdown
Contributor Author

I've fixed the test failure by adding the missing set enable_llvm_abi_extensions.

@fitzgen fitzgen enabled auto-merge July 30, 2024 20:11
@fitzgen fitzgen added this pull request to the merge queue Jul 30, 2024
Merged via the queue into bytecodealliance:main with commit 86bd6c8 Jul 30, 2024
@beetrees beetrees deleted the f16-f128-x64-mvp branch July 30, 2024 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants