Skip to content

Get Pulley tests passing under MIRI; run Pulley tests under MIRI in CI#9014

Merged
fitzgen merged 5 commits intobytecodealliance:mainfrom
fitzgen:pulley-miri
Jul 25, 2024
Merged

Get Pulley tests passing under MIRI; run Pulley tests under MIRI in CI#9014
fitzgen merged 5 commits intobytecodealliance:mainfrom
fitzgen:pulley-miri

Conversation

@fitzgen
Copy link
Copy Markdown
Member

@fitzgen fitzgen commented Jul 25, 2024

No description provided.

fitzgen and others added 3 commits July 25, 2024 15:56
Co-Authored-By: Alex Crichton <alex@alexcrichton.com>
Co-Authored-By: Alex Crichton <alex@alexcrichton.com>
@fitzgen fitzgen requested a review from a team as a code owner July 25, 2024 22:59
@fitzgen fitzgen requested review from cfallin and removed request for a team July 25, 2024 22:59
Copy link
Copy Markdown
Member

@cfallin cfallin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; I don't pretend to be an expert in Rust's pointer provenance model, but miri certainly is, and if miri is happy then so am I!

@fitzgen
Copy link
Copy Markdown
Member Author

fitzgen commented Jul 25, 2024

I don't pretend to be an expert in Rust's pointer provenance model, but miri certainly is, and if miri is happy then so am I!

same!

thanks

@fitzgen fitzgen added this pull request to the merge queue Jul 25, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 25, 2024
@fitzgen fitzgen enabled auto-merge July 25, 2024 23:35
@fitzgen fitzgen added this pull request to the merge queue Jul 25, 2024
Merged via the queue into bytecodealliance:main with commit ef1ffa2 Jul 25, 2024
@fitzgen fitzgen deleted the pulley-miri branch July 25, 2024 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants