Add basic pulley disassembly support to clif-util#9721
Merged
abrown merged 2 commits intobytecodealliance:mainfrom Dec 4, 2024
Merged
Add basic pulley disassembly support to clif-util#9721abrown merged 2 commits intobytecodealliance:mainfrom
clif-util#9721abrown merged 2 commits intobytecodealliance:mainfrom
Conversation
Helpful when running `clif-util compile -D --target pulley64` over the input.
alexcrichton
commented
Dec 3, 2024
| need_space = true; | ||
| } | ||
| for _ in 0..11_usize.saturating_sub(size) { | ||
| for _ in 0..12_usize.saturating_sub(size) { |
Member
Author
There was a problem hiding this comment.
This was done to make the disassembly a bit prettier since otherwise the hexdump and instructions might be side-by-side (no whitespace between)
Subscribe to Label Actioncc @fitzgen DetailsThis issue or pull request has been labeled: "cranelift", "pulley"Thus the following users have been cc'd because of the following labels:
To subscribe or unsubscribe from this label, edit the |
abrown
approved these changes
Dec 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Helpful when running
clif-util compile -D --target pulley64over the input.