winch: Prefer using Context::without for fuel checks#9709
Merged
cfallin merged 1 commit intobytecodealliance:mainfrom Dec 4, 2024
Merged
winch: Prefer using Context::without for fuel checks#9709cfallin merged 1 commit intobytecodealliance:mainfrom
Context::without for fuel checks#9709cfallin merged 1 commit intobytecodealliance:mainfrom
Conversation
This commit is a follow-up to bytecodealliance#9472. It ensures that the fuel checking code makes use of `Context::without` to retrieve the current fuel register. Even though no issues have been found, it is preferable to use `Context::without` in scenarios in which we have to introduce special out-of-band control flow and function calls to ensure that all the register allocation invariants are respected i.e., avoid holding onto to registers that: are not in the stack and that might be needed for function calls.
Subscribe to Label ActionDetailsThis issue or pull request has been labeled: "winch"Thus the following users have been cc'd because of the following labels:
To subscribe or unsubscribe from this label, edit the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit is a follow-up to
#9472. It ensures that the fuel checking code makes use of
Context::withoutto retrieve the current fuel register.Even though no issues have been found, it is preferable to use
Context::withoutin scenarios in which we have to introduce special out-of-band control flow and function calls to ensure that all the register allocation invariants are respected i.e., avoid holding onto to registers that: are not in the stack and that might be needed for function calls.