Skip to content

Backport 9196 to release-25.0.0#9204

Merged
alexcrichton merged 2 commits intobytecodealliance:release-25.0.0from
elliottt:trevor/backport-9196
Sep 6, 2024
Merged

Backport 9196 to release-25.0.0#9204
alexcrichton merged 2 commits intobytecodealliance:release-25.0.0from
elliottt:trevor/backport-9196

Conversation

@elliottt
Copy link
Copy Markdown
Member

@elliottt elliottt commented Sep 6, 2024

Backport #9196 to the release-25.0.0 branch, and add a RELEASES.md entry for it.

elliottt and others added 2 commits September 5, 2024 16:57
…ytecodealliance#9196)

* Use the CallHook::CallingHost and ReturningFromHost with components

We never implemented calling the CallingHost and ReturningFromHost hooks
for component host calls.

co-authored-by: Nick Fitzgerald <fitzgen@gmail.com>

* Add tests

* Run hooks under `catch_unwind_and_longjmp`

* Cleanup the imports

* Remove todo

* Ensure that returning hooks are run

* Appease clippy

* Suggestions from code review

* Reuse infrastructure from the core-wasm call-hook test

* Remove redundant test

* Add a realloc test

* Switch the realloc test to handle returning a string

* Rework the realloc test to check that we're tracking host reallocs

* Use the call hook in the realloc host call

* Unnecessary pub mod

* Add a post-return test

* Remove unnecessary assertions

* Format

* Remove incorrect hook calls for realloc uses

---------

Co-authored-by: Nick Fitzgerald <fitzgen@gmail.com>
@elliottt elliottt requested review from a team as code owners September 6, 2024 00:01
@elliottt elliottt requested review from alexcrichton and removed request for a team September 6, 2024 00:01
@alexcrichton alexcrichton merged commit 32f504e into bytecodealliance:release-25.0.0 Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants