cranelift-frontend: Make assert_eq_output! usable in the whole crate#9070
Merged
alexcrichton merged 1 commit intobytecodealliance:mainfrom Aug 2, 2024
Conversation
This moves the macro to `lib.rs` so that it can be used in all the tests in the whole crate. It also makes it a little more usable by trimming whitespace and printing both the expected and actual values, in addition to the diff. A follow-up commit will migrate various uses of `assert_eq!` over to it. Co-Authored-By: Trevor Elliot <telliott@fastly.com>
alexcrichton
approved these changes
Aug 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This moves the macro to
lib.rsso that it can be used in all the tests in the whole crate. It also makes it a little more usable by trimming whitespace and printing both the expected and actual values, in addition to the diff.A follow-up commit will migrate various uses of
assert_eq!over to it.