Fix the Target::pointer_width value on x32 and ilp32 targets.#98
Merged
Fix the Target::pointer_width value on x32 and ilp32 targets.#98
Target::pointer_width value on x32 and ilp32 targets.#98Conversation
x32 and ilp32 are ABI variants on x86_64 and aarch64 platforms where pointers have 32-bit, even though the CPU architectures are 64-bit. Fix target-lexicon to correctly report the pointer width for these. Fixes #97.
6288d51 to
630b531
Compare
fitzgen
approved these changes
Jan 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
x32 and ilp32 are ABI variants on x86_64 and aarch64 platforms where pointers have 32-bit, even though the CPU architectures are 64-bit. Fix target-lexicon to correctly report the pointer width for these.
Fixes #97.