Restore Signal::from_raw as Signal::from_named_raw.#1406
Merged
sunfishcode merged 3 commits intomainfrom Mar 16, 2025
Merged
Conversation
Rust 1.0 moved `Signal::from_raw` into a [separate crate], since properly supporting `SIGRTMIN+n` signals requires querying libc. But it's still useful to have a version of this function in rustix which is just documented to not support `SIGRTMIN+n` signals, so re-introduce it, with a different name and with appropriatet documentation. [separate crate]: https://crates.io/crates/rustix-libc-wrappers
9af49c5 to
f2048c5
Compare
Member
Author
|
This is restoring the functionality that previously was provided by |
Signal::from_named_raw constructor.Signal::from_raw as Signal::from_named_raw.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rust 1.0 moved
Signal::from_rawinto a separate crate, since properly supportingSIGRTMIN+nsignals requires querying libc. But it's still useful to have a version of this function in rustix which is just documented to not supportSIGRTMIN+nsignals, so re-introduce it, with a different name and with appropriatet documentation.