Conversation
DrJosh9000
reviewed
Nov 20, 2025
Contributor
There was a problem hiding this comment.
What if we deleted this interface?
Contributor
Author
There was a problem hiding this comment.
i've thought about it many times. it's basically pointless.
We were never using this for any of the useful things an interface provides
DrJosh9000
approved these changes
Nov 20, 2025
DrJosh9000
left a comment
Contributor
There was a problem hiding this comment.
LGTM, great work all around 🥇
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
What if the formatting was a little bit nicer?
Changes
gofmtwithgofumptin CIgofumpt -extra -w .across the entire repoTesting
go test ./...). Buildkite employees may check this if the pipeline has run automatically.go fmt ./...)Disclosures / Credits
I guess a computer did most of the work here, but it was the old-fashioned kind.