Support annotated tags for push git metadata#3013
Merged
emcfarlane merged 1 commit intomainfrom May 28, 2024
Merged
Conversation
Fix resolving of annotated tags by fetching from the remote and then using `--points-at` to discover each ref and tag. Currently only lightweight tags are resolved as the commit sha for annotated tags doesn't directly point to the commit.
doriable
approved these changes
May 28, 2024
Member
doriable
left a comment
There was a problem hiding this comment.
This seems reasonable to me -- it makes sense to grab the annotated tags for a commit the same way we are grabbing remote branches. Thanks for putting this through!
bufdev
approved these changes
May 28, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix resolving of annotated tags on push with
--git-metadataflag by fetching from the remote and then using--points-atto discover each ref and tag. Currently only lightweight tags are resolved as the commit sha for annotated tags doesn't directly point to the commit.