Map target paths and target exclude paths for archive/git refs#3003
Merged
Map target paths and target exclude paths for archive/git refs#3003
Conversation
Member
|
Needs changelog entry for when we do 1.32.1 release |
nicksnyder
reviewed
May 21, 2024
Co-authored-by: Nick Snyder <nickdsnyder@gmail.com>
nicksnyder
reviewed
May 21, 2024
Co-authored-by: Nick Snyder <nickdsnyder@gmail.com>
bufdev
approved these changes
May 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In CLI versions pre-1.32.0, for archive and git refs, we would map
the root of the bucket of archive and git refs to the
subDirPath,which is inconsistent with the behavior for dir refs (which maps
target paths and target exclude paths to the execution context).
In 1.32.0, we made changes to handle subDirPath, target paths,
and target exclude paths in a unified way, however this is not
backwards compatible with pre-1.32.0 versions. So, in order
to be backwards compatible, we need to remap the target
paths and target exclude paths.
I explored an option to check of the subDirPath contains
the target paths and target exclude paths before remapping,
however this is brittle, since we could hit an edge case with
directories that have the same name nested:
Tests have been adjusted to reflect this change.