Add revision to GetRemotePackageVersionPlugin#2989
Merged
stefanvanburen merged 1 commit intomainfrom May 17, 2024
Merged
Conversation
We're now using these RPCs to power the BSR UI, which need to be able to specify this field. Not currently adding it to the CLI calls, which will continue to leave this unspecified (meaning the latest revision).
paul-sachs
approved these changes
May 17, 2024
stefanvanburen
commented
May 17, 2024
| string version = 3; | ||
| // The revision of the plugin version. | ||
| // example: 1 | ||
| uint32 revision = 4; |
Member
Author
There was a problem hiding this comment.
FWIW, I believe we originally kept this message different from CuratedPluginReference due to the inability to specify this field, but it's now exactly the same, field-wise.
bufdev
approved these changes
May 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We're now using these RPCs to power the BSR UI, which need to be able to specify this field. Not currently adding it to the CLI calls, which will continue to leave this unspecified (meaning the latest revision).