Get/Set repositories' default branch field#2326
Merged
unmultimedio merged 7 commits intomainfrom Jul 31, 2023
Merged
Conversation
unmultimedio
commented
Jul 28, 2023
unmultimedio
commented
Jul 28, 2023
seankimdev
approved these changes
Jul 28, 2023
Contributor
seankimdev
left a comment
There was a problem hiding this comment.
Lgtm, just non-blocking question/comment.
| // always included the scheme and will not have a #fragment suffix. | ||
| string url = 12; | ||
| // default_branch in a BSR repository. It is used when syncing a git repository, to make sure both | ||
| // default branches (BSR and Git) are in sync. By default, every BSR repository is created with a |
Contributor
There was a problem hiding this comment.
What happens if the default branches (BSR and Git) are out of sync? Would it reject the sync until the user manually changes the default branch in BSR to match?
Member
Author
There was a problem hiding this comment.
That's correct, but that's in the buf sync scope, in an upcoming PR.
doriable
approved these changes
Jul 31, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows
buf alpha repo synccommand to check if the local git default branch matches the BSR's, and abort if they don't.