Remove GetRemotePackageVersion and Add Get<registry>Version in protos #2218
Merged
Remove GetRemotePackageVersion and Add Get<registry>Version in protos #2218
Conversation
Member
stefanvanburen
left a comment
There was a problem hiding this comment.
looks fine, just needs updates to comments
|
|
||
| // GetRemotePackageVersion resolves the given plugin and module references to a version. | ||
| // GetGoVersion resolves the given plugin and module references to a version. | ||
| // The format of the version is determined by the plugin type. |
Member
There was a problem hiding this comment.
Suggested change
| // The format of the version is determined by the plugin type. |
I think you can nix the second line for each of these, as the format of the version is fixed per-registry.
| option idempotency_level = NO_SIDE_EFFECTS; | ||
| } | ||
| // GetSwiftVersion resolves the given plugin and module references to a version. | ||
| // The format of the version is determined by the plugin type. |
Member
There was a problem hiding this comment.
Suggested change
| // The format of the version is determined by the plugin type. |
| option idempotency_level = NO_SIDE_EFFECTS; | ||
| } | ||
| // GetMavenVersion resolves the given plugin and module references to a version. | ||
| // The format of the version is determined by the plugin type. |
Member
There was a problem hiding this comment.
Suggested change
| // The format of the version is determined by the plugin type. |
| option idempotency_level = NO_SIDE_EFFECTS; | ||
| } | ||
| // GetNPMVersion resolves the given plugin and module references to a version. | ||
| // The format of the version is determined by the plugin type. |
Member
There was a problem hiding this comment.
Suggested change
| // The format of the version is determined by the plugin type. |
| } | ||
|
|
||
| message GetMavenVersionResponse { | ||
| // version is the resolved version to be used with the go module proxy. |
Member
There was a problem hiding this comment.
Suggested change
| // version is the resolved version to be used with the go module proxy. | |
| // version is the resolved version to be used with the maven repository. |
| } | ||
|
|
||
| message GetNPMVersionResponse { | ||
| // version is the resolved version to be used with the go module proxy. |
Member
There was a problem hiding this comment.
Suggested change
| // version is the resolved version to be used with the go module proxy. | |
| // version is the resolved version to be used with the npm registry. |
| } | ||
|
|
||
| message GetSwiftVersionResponse { | ||
| // version is the resolved version to be used with the go module proxy. |
Member
There was a problem hiding this comment.
Suggested change
| // version is the resolved version to be used with the go module proxy. | |
| // version is the resolved version to be used with the swift repository. |
| } | ||
|
|
||
| message GetMavenVersionResponse { | ||
| // version is the resolved version to be used with the maven registry. |
Member
There was a problem hiding this comment.
Suggested change
| // version is the resolved version to be used with the maven registry. | |
| // version is the resolved version to be used with the maven repository. |
Contributor
Author
There was a problem hiding this comment.
We use the term registry everywhere don't we?
Contributor
Author
There was a problem hiding this comment.
nvm apparently it's different for maven
stefanvanburen
approved these changes
Jun 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added directly from #2182 but I don't want to merge that because it's not in main in core yet and it can't be added to core yet because it isn't in main on buf yet so I'm making this PR so that I can implement it in core and then rebase buf