Conversation
pkwarren
approved these changes
Jun 3, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
ModuleIdentityand commit were not being set when returning aModulefrom the cache. In the constructors ofModule, we have a comment saying that we rely on a level higher, i.e.ModuleReader, to set identity and commit information since we do not store this in the proto representation. We were properly doing this with the delegate (i.e. inbufapimodule), but not doing this in the cache.This has only been a problem since the new CAS cache was released, this was previously properly done in the cache, but the option was omitted when the new CAS cache was introduced:
buf/private/bufpkg/bufmodule/bufmodulecache/module_cacher.go
Line 75 in 5d03706