Remove beta tamper proofing feature flag#2099
Merged
Conversation
pkwarren
commented
May 17, 2023
| - '^exec\.Command$' | ||
| - '^exec\.CommandContext$' | ||
| # This should only be used by github.com/bufbuild/buf-language-server | ||
| - '^bufcli\.NewModuleReaderAndCreateCacheDirsWithExternalPaths' |
Member
Author
There was a problem hiding this comment.
The LSP will need to be updated to support new cache paths.
Member
There was a problem hiding this comment.
The LSP was just a prototype and isn't being actively developed, we don't need to update it
| } | ||
|
|
||
| func TestPushCreate(t *testing.T) { | ||
| func TestPushManifestCreate(t *testing.T) { |
Member
Author
There was a problem hiding this comment.
Retrofitted the new push --create tests to use the M+B endpoint.
bufdev
approved these changes
May 17, 2023
unmultimedio
approved these changes
May 17, 2023
Member
unmultimedio
left a comment
There was a problem hiding this comment.
Looking nice and clean 👍🏼
| ) | ||
| } | ||
| if err := checkExistingCacheDirs(container.CacheDirPath(), cacheDirsToCreate...); err != nil { | ||
| if err := createCacheDirs(cacheModuleDirPathV2); err != nil { |
Member
There was a problem hiding this comment.
Probably worth a changelog entry saying that once updating to this version, cache dir will be different, hence "apparently cleaned up"?
unmultimedio
approved these changes
May 17, 2023
Co-authored-by: Julian Figueroa <jfigueroa@buf.build>
unmultimedio
approved these changes
May 17, 2023
unmultimedio
approved these changes
May 17, 2023
bufdev
approved these changes
May 17, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.