Throw ctx cancelled error in thread.Parallelize#2089
Merged
unmultimedio merged 2 commits intomainfrom May 16, 2023
Merged
Conversation
doriable
approved these changes
May 16, 2023
Member
doriable
left a comment
There was a problem hiding this comment.
This is a good find! Stamping, but may want input from others also :)
bufdev
reviewed
May 16, 2023
Member
bufdev
left a comment
There was a problem hiding this comment.
I'd probably delete the jobIdx stuff, see comments
private/pkg/thread/thread.go
Outdated
| select { | ||
| case <-ctx.Done(): | ||
| stop = true | ||
| retErr = multierr.Append(retErr, fmt.Errorf("jobs[%d]: context canceled", jobIdx)) |
Member
There was a problem hiding this comment.
This should likely be ctx.Err() instead of a custom error, some people parse the specific context canceled function
private/pkg/thread/thread.go
Outdated
| select { | ||
| case <-ctx.Done(): | ||
| stop = true | ||
| retErr = multierr.Append(retErr, fmt.Errorf("jobs[%d]: context canceled", jobIdx)) |
private/pkg/thread/thread.go
Outdated
| if err := job(ctx); err != nil { | ||
| lock.Lock() | ||
| retErr = multierr.Append(retErr, err) | ||
| retErr = multierr.Append(retErr, fmt.Errorf("jobs[%d]: %w", jobIdx, err)) |
Member
There was a problem hiding this comment.
I can see it both ways, I might lean to not doing a custom error at all - I know you're using %w so it can be unrolled, but no need to expose to the user that this is parallel job at all IMO
bufdev
reviewed
May 16, 2023
bufdev
approved these changes
May 16, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found a panic in a test, caused because of a DX assumption. From users perspective, doing:
I will test in a dependent repo before making this ready for review.Tested.