Skip to content

Upgrade deps including wazero v1.0.0#1942

Merged
pkwarren merged 1 commit intomainfrom
pkw/upgrade-deps
Mar 27, 2023
Merged

Upgrade deps including wazero v1.0.0#1942
pkwarren merged 1 commit intomainfrom
pkw/upgrade-deps

Conversation

@pkwarren
Copy link
Member

No description provided.

@pkwarren pkwarren requested review from saquibmian and twoism March 27, 2023 17:38
Copy link
Contributor

@saquibmian saquibmian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@pkwarren
Copy link
Member Author

Looked through the changelog - the one potential simplification we could make would be to remove

if exitErr.ExitCode() == 0 {
return nil
}
, however I didn't audit all the code paths to make sure that's safe.

@pkwarren pkwarren merged commit 759d0e8 into main Mar 27, 2023
@pkwarren pkwarren deleted the pkw/upgrade-deps branch March 27, 2023 17:44
Monirul1 pushed a commit to Monirul1/buf that referenced this pull request Apr 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants