Clarify that format takes a source and not an input#1895
Merged
Conversation
bufdev
reviewed
Mar 7, 2023
| Output string | ||
| Write bool | ||
| // special | ||
| InputHashtag string |
Member
There was a problem hiding this comment.
InputHashtag is the same name across all commands, it's a special variable and matches with bufcli.GetInputValue naming, updating this would make format the one inconsistent command here - I'd like to keep this the same so you can grep for this in the future
added 2 commits
March 7, 2023 12:59
…urce' into fix/format-input-source
bufdev
approved these changes
Mar 7, 2023
Monirul1
pushed a commit
to Monirul1/buf
that referenced
this pull request
Apr 30, 2023
`buf format` does not take an `input` but a `source` The following command fails ``` buf build | buf format - Failure: format was "bin" but must be one of [dir,git,mod,protofile,tar,targz,zip] ``` and therefore the correct terminology to use is `source`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
buf formatdoes not take aninputbut asourceThe following command fails
and therefore the correct terminology to use is
source