Merged
Conversation
When migrating a v1beta1 external config to a plugin config, we should
only set the new path slice if the path in the config is non-empty.
Otherwise, we'll try to exec an empty command by initializing the slice
to {""}.
pkwarren
commented
Mar 7, 2023
| Strategy: strategy, | ||
| } | ||
| if plugin.Path != "" { | ||
| pluginConfig.Path = []string{plugin.Path} |
| config, err = ReadConfig(ctx, nopLogger, provider, readBucket, ReadConfigWithOverride(string(data))) | ||
| require.NoError(t, err) | ||
| require.Equal(t, successConfig3, config) | ||
| testReadConfigSuccess := func(t *testing.T, configPath string, expected *Config) { |
Member
Author
There was a problem hiding this comment.
Refactored some duplicated code into a common function.
| plugins: | ||
| - name: go | ||
| out: gen/go | ||
| strategy: all |
Member
Author
There was a problem hiding this comment.
Sample config without a path specified so we can verify the fix.
tonyli233
approved these changes
Mar 7, 2023
bufdev
approved these changes
Mar 7, 2023
Monirul1
pushed a commit
to Monirul1/buf
that referenced
this pull request
Apr 30, 2023
When migrating a v1beta1 external config to a plugin config, we should
only set the new path slice if the path in the config is non-empty.
Otherwise, we'll try to exec an empty command by initializing the slice
to `{""}`.
Fixes bufbuild#1850.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When migrating a v1beta1 external config to a plugin config, we should only set the new path slice if the path in the config is non-empty. Otherwise, we'll try to exec an empty command by initializing the slice to
{""}.Fixes #1850.