Enable the RpcClient to send requests to Bitcoin Core over a Unix socket.#2168
Merged
jcvernaleo merged 1 commit intobtcsuite:masterfrom Jun 26, 2024
Merged
Enable the RpcClient to send requests to Bitcoin Core over a Unix socket.#2168jcvernaleo merged 1 commit intobtcsuite:masterfrom
jcvernaleo merged 1 commit intobtcsuite:masterfrom
Conversation
Contributor
SulaimanAminuBarkindo
left a comment
There was a problem hiding this comment.
Thanks for this pull request!
Overall, this pull request looks good and seems like a valuable addition to btcd. To further improve its usability and clarity, I have a couple of suggestions:
Example Usage: It would be helpful to add some example usage demonstrations in the examples folder for the rpcclient with this new functionality. This would make it easier for users to understand how to use the new feature in practice.
Testing: To further improve the clarity of the pull request, consider adding some steps to the PR description outlining how to test the newly implemented functionality with Unix sockets. This would be beneficial for both reviewers and future users.
Contributor
Author
|
Great! I've included an example that should clarify how to test it further. The only tricky part is that a host needs to be passed to avoid raising errors. The value doesn't matter as long as it's valid. If the client has a default value, this shouldn't be a problem. Perhaps when setting the DialContext, we can hard code a value like |
SulaimanAminuBarkindo
approved these changes
Apr 24, 2024
Contributor
SulaimanAminuBarkindo
left a comment
There was a problem hiding this comment.
Thank you for providing the example files.
LGTM
guggero
reviewed
Apr 24, 2024
Contributor
Author
|
Updated the code. I didn't set a default port when calling |
Pull Request Test Coverage Report for Build 8907194933Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
SulaimanAminuBarkindo
approved these changes
May 6, 2024
guggero
reviewed
May 10, 2024
Collaborator
guggero
left a comment
There was a problem hiding this comment.
Thanks for the updates. Looks better now, but still got a couple of asks.
Sending RPC requests through unix sockets
Contributor
Author
|
Great! Thank you for reviewing. I've implemented the suggested changes. |
Contributor
Author
|
Any update on this? @guggero |
guggero
approved these changes
Jun 20, 2024
torkelrogstad
added a commit
to barebitcoin/btcd
that referenced
this pull request
Sep 19, 2024
btcfind
pushed a commit
to btcfind/btcd
that referenced
this pull request
Sep 26, 2024
Sending RPC requests through unix sockets
same-id
added a commit
to same-id/btcd
that referenced
this pull request
Oct 27, 2024
A fix for a bug introduced by btcsuite#2168 Previously, config.Host worked in the following way: 1. Documented as supporting ip addresses only 2. In fact supported "host/path" syntax 3. Did not support "scheme" prefixes, i.e. https:// Not sure this is the desired approach, probably the best thing would have been to extend config to contain "Scheme" and "Path" fields as well. However, this was the way it worked. 1. Now Host can contain scheme prefixes "unix://..." 2. Host can no longer contain ".../path" This PR solves this behavior while maintaining support of the "unix://" flow as well. For some reason, "scheme" is named "network" in btcsuite#2168 - I did not change that.
same-id
added a commit
to same-id/btcd
that referenced
this pull request
Oct 27, 2024
A fix for a bug introduced by btcsuite#2168 Previously, config.Host worked in the following way: 1. Documented as supporting ip addresses only 2. In fact supported "host/path" syntax 3. Did not support "scheme" prefixes, i.e. https:// Not sure this is the desired approach, probably the best thing would have been to extend config to contain "Scheme" and "Path" fields as well. However, this was the way it worked. 1. Now Host can contain scheme prefixes "unix://..." 2. Host can no longer contain ".../path" This PR solves this behavior while maintaining support of the "unix://" flow as well. For some reason, "scheme" is named "network" in btcsuite#2168 - I did not change that. Also remove disambiguation in "network:address:port", where it parsed "myhost:8888" as network:address instead address:port.
same-id
added a commit
to same-id/btcd
that referenced
this pull request
Oct 28, 2024
A fix for a bug introduced by btcsuite#2168 Previously, config.Host worked in the following way: 1. Documented as supporting ip addresses only 2. In fact supported "host/path" syntax 3. Did not support "scheme" prefixes, i.e. https:// Not sure this is the desired approach, probably the best thing would have been to extend config to contain "Scheme" and "Path" fields as well. However, this was the way it worked. 1. Now Host can contain scheme prefixes "unix://..." 2. Host can no longer contain ".../path" This PR solves this behavior while maintaining support of the "unix://" flow as well. For some reason, "scheme" is named "network" in btcsuite#2168 - I did not change that. Also remove disambiguation in "network:address:port", where it parsed "myhost:8888" as network:address instead address:port.
same-id
added a commit
to same-id/btcd
that referenced
this pull request
Oct 28, 2024
A fix for a bug introduced by btcsuite#2168 Previously, config.Host worked in the following way: 1. Documented as supporting ip addresses only 2. In fact supported "host/path" syntax 3. Did not support "scheme" prefixes, i.e. https:// Not sure this is the desired approach, probably the best thing would have been to extend config to contain "Scheme" and "Path" fields as well. However, this was the way it worked. 1. Now Host can contain scheme prefixes "unix://..." 2. Host can no longer contain ".../path" This PR solves this behavior while maintaining support of the "unix://" flow as well. For some reason, "scheme" is named "network" in btcsuite#2168 - I did not change that. Also remove disambiguation in "network:address:port", where it parsed "myhost:8888" as network:address instead address:port.
same-id
added a commit
to same-id/btcd
that referenced
this pull request
Oct 28, 2024
A fix for a bug introduced by btcsuite#2168 Previously, config.Host worked in the following way: 1. Documented as supporting ip addresses only 2. In fact supported "host/path" syntax 3. Did not support "scheme" prefixes, i.e. https:// Not sure this is the desired approach, probably the best thing would have been to extend config to contain "Scheme" and "Path" fields as well. However, this was the way it worked. 1. Now Host can contain scheme prefixes "unix://..." 2. Host can no longer contain ".../path" This PR solves this behavior while maintaining support of the "unix://" flow as well. For some reason, "scheme" is named "network" in btcsuite#2168 - I did not change that. Also remove disambiguation in "network:address:port", where it parsed "myhost:8888" as network:address instead address:port.
same-id
added a commit
to same-id/btcd
that referenced
this pull request
Oct 28, 2024
A fix for a bug introduced by btcsuite#2168 Previously, config.Host worked in the following way: 1. Documented as supporting ip addresses only 2. In fact supported "host/path" syntax 3. Did not support "scheme" prefixes, i.e. https:// Not sure this is the desired approach, probably the best thing would have been to extend config to contain "Scheme" and "Path" fields as well. However, this was the way it worked. 1. Now Host can contain scheme prefixes "unix://..." 2. Host can no longer contain ".../path" This PR solves this behavior while maintaining support of the "unix://" flow as well. For some reason, "scheme" is named "network" in btcsuite#2168 - I did not change that. Also remove disambiguation in "network:address:port", where it parsed "myhost:8888" as network:address instead address:port.
same-id
added a commit
to same-id/btcd
that referenced
this pull request
Oct 29, 2024
A fix for a bug introduced by btcsuite#2168 Previously, config.Host worked in the following way: 1. Documented as supporting ip addresses only 2. In fact supported "host/path" syntax 3. Did not support "scheme" prefixes, i.e. https:// Not sure this is the desired approach, probably the best thing would have been to extend config to contain "Scheme" and "Path" fields as well. However, this was the way it worked. 1. Now Host can contain scheme prefixes "unix://..." 2. Host can no longer contain ".../path" This PR solves this behavior while maintaining support of the "unix://" flow as well. For some reason, "scheme" is named "network" in btcsuite#2168 - I did not change that. Also remove disambiguation in "network:address:port", where it parsed "myhost:8888" as network:address instead address:port.
same-id
added a commit
to same-id/btcd
that referenced
this pull request
Nov 8, 2024
A fix for a bug introduced by btcsuite#2168 Previously, config.Host worked in the following way: 1. Documented as supporting ip addresses only 2. In fact supported "host/path" syntax 3. Did not support "scheme" prefixes, i.e. https:// Not sure this is the desired approach, probably the best thing would have been to extend config to contain "Scheme" and "Path" fields as well. However, this was the way it worked. 1. Now Host can contain scheme prefixes "unix://..." 2. Host can no longer contain ".../path" This PR solves this behavior while maintaining support of the "unix://" flow as well. For some reason, "scheme" is named "network" in btcsuite#2168 - I did not change that. Also remove disambiguation in "network:address:port", where it parsed "myhost:8888" as network:address instead address:port.
same-id
added a commit
to same-id/btcd
that referenced
this pull request
Dec 5, 2024
A fix for a bug introduced by btcsuite#2168 Previously, config.Host worked in the following way: 1. Documented as supporting ip addresses only 2. In fact supported "host/path" syntax 3. Did not support "scheme" prefixes, i.e. https:// Not sure this is the desired approach, probably the best thing would have been to extend config to contain "Scheme" and "Path" fields as well. However, this was the way it worked. 1. Now Host can contain scheme prefixes "unix://..." 2. Host can no longer contain ".../path" This PR solves this behavior while maintaining support of the "unix://" flow as well. For some reason, "scheme" is named "network" in btcsuite#2168 - I did not change that. Also remove disambiguation in "network:address:port", where it parsed "myhost:8888" as network:address instead address:port.
lcmmhcc
reviewed
Nov 19, 2025
|
|
||
| // Addresses can either be in network://address:port format, | ||
| // network:address:port, address:port, or just port. We want to support | ||
| // all possible types. |
There was a problem hiding this comment.
i guess u don't support the address like "https://getblock.io", which is supported in v0.24.2, @robertmin1
JeremyRand
pushed a commit
to JeremyRand/btcd
that referenced
this pull request
Mar 5, 2026
The previous description incorrectly implied that Unix sockets were not supported (support was added in btcsuite#2168).
7 tasks
hieblmi
added a commit
to hieblmi/btcd
that referenced
this pull request
Mar 10, 2026
When ConnConfig.Host contains a scheme prefix (e.g. "https://go.getblock.io/xxxx"), ParseAddressString rejects it because it contains "://" which is only supported for unix:// addresses. This was introduced by the unix socket support in PR btcsuite#2168. Add stripScheme and extractHostPort helpers so that newHTTPClient and httpURL strip any http:// or https:// prefix before address parsing, since the scheme is already determined by the DisableTLS field. Fixes btcsuite#2464.
asheswook
pushed a commit
to asheswook/btcd
that referenced
this pull request
Apr 2, 2026
Sending RPC requests through unix sockets
asheswook
pushed a commit
to asheswook/btcd
that referenced
this pull request
Apr 2, 2026
A fix for a bug introduced by btcsuite#2168 Previously, config.Host worked in the following way: 1. Documented as supporting ip addresses only 2. In fact supported "host/path" syntax 3. Did not support "scheme" prefixes, i.e. https:// Not sure this is the desired approach, probably the best thing would have been to extend config to contain "Scheme" and "Path" fields as well. However, this was the way it worked. 1. Now Host can contain scheme prefixes "unix://..." 2. Host can no longer contain ".../path" This PR solves this behavior while maintaining support of the "unix://" flow as well. For some reason, "scheme" is named "network" in btcsuite#2168 - I did not change that. Also remove disambiguation in "network:address:port", where it parsed "myhost:8888" as network:address instead address:port.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enable the RpcClient to send requests to Bitcoin Core over a Unix socket.
Issue #2149